Hello I'm uncertain how _txm_module_manager_stop.c should be compiled when TraceX is in use. I defined TX_ENABLE_EVENT_TRACE. Then I observe IAR compiler errors when compiling _txm_module_manager_stop.c. The identifiers '_tx_trace_buffer_current_ptr' and '_tx_trace_header_ptr' are undefined. I think including of the file tx_trace.h is missing. Questions: Is it safe to include tx_trace.h after tx_api.h on top of file _txm_module_manager_stop.c? Is it intended to modify the ThreadX source code in this situation? Or am I missing something like a configuration option? May you judge this as a bug. Then it would be helpful to resolve it in next release of TraceX/ThreadX. Thanks Peter

Hi @HugPeter-9392 , thank you for posting this question. I have looked into the ThreadX GitHub repository to check the dependency between tx_trace.h and TX_ENABLE_EVENT_TRACE. I have found a file tx_block_allocate.c in which they define TX_ENABLE_EVENT_TRACE. From the header's section it looks like the program needs tx_trace.h to be included when we define this parameter. Please refer the following code snippet for your reference #include "tx_api.h" #ifdef TX_ENABLE_EVENT_TRACE #include "tx_trace.h" #endif #include "tx_thread.h" #include "tx_block_pool.h" Since the headers here include both "tx_api.h" and "tx_trace.h", I hope this answers your question 1. You can modify the code per your needs and define the features and addons you need. Please refer to point 3 of Building and Using library section. Kindly let us know if the above shared information is useful. Please reach out to us if you need further clarification or assistance on this.

Compilation error in _txm_module_manager_stop.c when TX_ENABLE_EVENT_TRACE is defined

HugPeter-9392 246

Hello
I'm uncertain how _txm_module_manager_stop.c should be compiled when TraceX is in use.

I defined TX_ENABLE_EVENT_TRACE. Then I observe IAR compiler errors when compiling _txm_module_manager_stop.c. The identifiers '_tx_trace_buffer_current_ptr' and '_tx_trace_header_ptr' are undefined. I think including of the file tx_trace.h is missing.

Questions:

Is it safe to include tx_trace.h after tx_api.h on top of file _txm_module_manager_stop.c?
Is it intended to modify the ThreadX source code in this situation? Or am I missing something like a configuration option?

May you judge this as a bug. Then it would be helpful to resolve it in next release of TraceX/ThreadX.

Thanks
Peter

LeelaRajeshSayana-MSFT 14,831 Reputation points Microsoft Employee

2023-01-09T12:33:36.773+00:00
Hi @HugPeter-9392 , thank you for your response. You can share the product feedback related to Azure TROS ThreadX through the following GitHub link -- Azure RTOS ThreadX Issues. Please refer the contributing guidelines that guides you how to post feedback. Please let me know if you need any further assistance on this issue.

Kindly accept answer or upvote if the response is helpful so that it would benefit other community members facing the same issue.

Original posters help the community find answers faster by identifying the correct answer. Here is how

I highly appreciate your contribution to the community.

1 answer

LeelaRajeshSayana-MSFT 14,831 Reputation points Microsoft Employee

2023-01-04T21:21:22.233+00:00
Hi @HugPeter-9392 , thank you for posting this question. I have looked into the ThreadX GitHub repository to check the dependency between tx_trace.h and TX_ENABLE_EVENT_TRACE. I have found a file tx_block_allocate.c in which they define TX_ENABLE_EVENT_TRACE. From the header's section it looks like the program needs tx_trace.h to be included when we define this parameter.

Please refer the following code snippet for your reference

#include "tx_api.h" #ifdef TX_ENABLE_EVENT_TRACE #include "tx_trace.h" #endif #include "tx_thread.h" #include "tx_block_pool.h"

Since the headers here include both "tx_api.h" and "tx_trace.h", I hope this answers your question 1.

You can modify the code per your needs and define the features and addons you need. Please refer to point 3 of Building and Using library section.

Kindly let us know if the above shared information is useful. Please reach out to us if you need further clarification or assistance on this.
Please sign in to rate this answer.
HugPeter-9392 246 Reputation points

2023-01-05T07:22:13.927+00:00

Hi LeelaRajeshSayana-MSFT

Thank you for your reply. It perfectly answers my question 1. Thanks.

For question 2 I'm not yet sure if it is intended that users of TraceX are expected to change ThreadX source code. As the documentation in threadx, point 3, states the file tx_user.h is intended to configure ThreadX. To me, it looks like a limitation in ThreadX 6.2.0 that it does not compile when TX_ENABLE_EVENT_TRACE is defined. Your proposed code snipped would fix the issue.

I'm not sure if this is the right place to ask or propose: Why not apply your code snipped to the next release of ThreadX?

Thanks for support
Peter

HugPeter-9392 246 Reputation points

2023-01-10T06:48:14.633+00:00

Hi LeelaRajeshSayana-MSFT

Thank you for your reply. It perfectly answers my question 1. Thanks.

For question 2 I'm not yet sure if it is intended that users of TraceX are expected to change ThreadX source code. As the documentation in threadx, point 3, states the file tx_user.h is intended to configure ThreadX. To me, it looks like a limitation in ThreadX 6.2.0 that it does not compile when TX_ENABLE_EVENT_TRACE is defined. Your proposed code snipped would fix the issue.

I'm not sure if this is the right place to ask or propose: Why not apply your code snipped to the next release of ThreadX?

Thanks for support Peter

LeelaRajeshSayana-MSFT 14,831 Reputation points Microsoft Employee

2023-01-10T15:38:25.36+00:00

Hi @HugPeter-9392 , thank you for your response. You can share the product feedback related to Azure TROS ThreadX through the following GitHub link -- Azure RTOS ThreadX Issues. Please refer the contributing guidelines that guides you how to post feedback. Please let me know if you need any further assistance on this issue.

Scott Azure RTOS 4,051 Reputation points

2023-01-10T23:43:16.07+00:00

Hi @HugPeter-9392 and @LeelaRajeshSayana-MSFT - I'll make the fix to the txm_module_manager_stop.c file.

Edit: just copy and paste this into the file below the rest of the #includes:

#ifdef TX_ENABLE_EVENT_TRACE #include "tx_trace.h" #endif

Cheers, Scott
Sign in to comment

Use comments to ask for clarification, additional information, or improvements to the question.

Share via

Compilation error in _txm_module_manager_stop.c when TX_ENABLE_EVENT_TRACE is defined

1 answer

Your answer